Udev fixes#9
Open
vidvidex wants to merge 13 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the udev-rule setup flow by replacing the older “setup new file / add to existing file” scripts with two clearer entry points (add from an existing rules template vs. generate from currently connected devices) and centralizing shared whiptail/udev helpers.
Changes:
- Add shared helper library (
udev_rules_common.sh) and new menu-driven scripts for adding rules from templates or connected devices. - Update/add udev rule templates (including owner placeholder usage) and remove legacy scripts.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| subscripts/5Udev_rules/DISREGARD_udev_rules/X500.rules | Updates template rule matching (USB interface numbers) for X500 distribution board devices. |
| subscripts/5Udev_rules/DISREGARD_udev_rules/robocore.rules | Adds a template rules file for robocore (ttyTHS0) mapping. |
| subscripts/5Udev_rules/DISREGARD_common/udev_rules_common.sh | Introduces shared whiptail/menu helpers and udevadm parsing utilities used by the new scripts. |
| subscripts/5Udev_rules/2Add_udev_rules_to_an_existing_file.sh | Removes legacy “add to existing file” implementation in favor of the new flow. |
| subscripts/5Udev_rules/2Add_from_currently_connected_devices.sh | Adds new flow for generating rules from connected devices and writing/appending to a selected target file. |
| subscripts/5Udev_rules/1Setup_new_udev_rules_file.sh | Removes legacy “setup new rules file” implementation in favor of the new flow. |
| subscripts/5Udev_rules/1Add_from_existing_rules_file.sh | Adds new flow for selecting a template rules file and writing/appending it to a target file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
New version: 
New flow for adding rules:
|
spurnvoj
reviewed
Jun 2, 2026
| # RULES for X500 Distribution Board | ||
| # Pixhawk | ||
| SUBSYSTEM=="tty", ATTRS{idVendor}=="0403", ATTRS{idProduct}=="6011", ENV{ID_USB_INTERFACE_NUM}=="03", SYMLINK+="pixhawk",OWNER="TO_BE_REPLACED",MODE="0666" | ||
| SUBSYSTEM=="tty", ATTRS{idVendor}=="0403", ATTRS{idProduct}=="6011", ENV{ID_USB_INTERFACE_NUM}=="02", SYMLINK+="pixhawk",OWNER="TO_BE_REPLACED",MODE="0666" |
Collaborator
Author
There was a problem hiding this comment.
Cherry-picked this commit from main: a27e377
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
On top level it now asks whether you want to add from a rules file or from currently connected devices (previously it asked if you have MRS distribution board and then always also asked about the connected devices)
For either option it then asks whether you want to create a new file with this rule or append to an existing file.